Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove users.register in favor of users.create #1770

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 7, 2025

Important

Remove users.register method and update all references to use users.create instead.

  • Behavior:
    • Remove register() method from UsersClient in users.ts.
    • Replace all client.users.register calls with client.users.create.
  • Tests:
    • Update test_chunks.py, test_documents.py, test_users.py, and loadTester.py to use users.create instead of users.register.
    • Ensure all tests reflect the new method usage and maintain functionality.

This description was created by Ellipsis for d228ad8. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 35e3449 in 21 seconds

More details
  • Looked at 139 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/tests/scaling/loadTester.py:72
  • Draft comment:
    Ensure that the create method provides the same functionality as the deprecated register method, including any side effects or additional logic that might have been present in register.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR correctly replaces the deprecated register method with create in the loadTester.py file. This ensures consistency with the updated API.

Workflow ID: wflow_pyr9KA0vTKPgaLMi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d66a03c in 13 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_fPu5ykwzIyoeZJty


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d228ad8 in 17 seconds

More details
  • Looked at 10 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_OLKEhSIdnczDQehn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit a624438 into main Jan 7, 2025
14 of 15 checks passed
@NolanTrem NolanTrem deleted the Nolan/UserCreate branch January 7, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant